fix: preserve background operator in allowlist segments
Maintainer edit: keep a top-level trailing '&' in the segment being matched so background execution cannot be checked as if the ampersand were absent. Redirection forms like 2>&1 and &> remain untouched.
This commit is contained in:
@@ -882,6 +882,7 @@ class ExecTool(Tool):
|
||||
elif ch == "&" and not (
|
||||
(i > 0 and command[i - 1] in "<>") or command.startswith("&>", i)
|
||||
):
|
||||
current.append(ch)
|
||||
operator_len = 1
|
||||
elif ch in {";", "|"}:
|
||||
operator_len = 1
|
||||
|
||||
@@ -76,6 +76,15 @@ def test_guard_allow_patterns_block_single_ampersand_chained_segment():
|
||||
assert "allowlist" in result.lower()
|
||||
|
||||
|
||||
def test_guard_allow_patterns_preserve_trailing_background_operator():
|
||||
tool = ExecTool(allow_patterns=[r"echo\s+allowlisted"])
|
||||
|
||||
result = tool._guard_command("echo allowlisted &", "/tmp")
|
||||
|
||||
assert result is not None
|
||||
assert "allowlist" in result.lower()
|
||||
|
||||
|
||||
def test_guard_allow_patterns_keep_fd_redirection_ampersand():
|
||||
tool = ExecTool(allow_patterns=[r"echo\s+allowlisted\s+2>&1"])
|
||||
|
||||
|
||||
Reference in New Issue
Block a user