fix(providers): tighten local endpoint detection

Parse the endpoint host before disabling keepalive so public hostnames that merely contain private-network substrings keep the default connection pool behavior.

Made-with: Cursor

nanobot/providers/openai_compat_provider.py

@@ -3,16 +3,18 @@
 from __future__ import annotations
 
 import asyncio
-import json
 import hashlib
 import importlib.util
+import json
 import os
 import secrets
 import string
 import time
 import uuid
 from collections.abc import Awaitable, Callable
+from ipaddress import ip_address
 from typing import TYPE_CHECKING, Any
+from urllib.parse import urlparse
 
 import httpx
 import json_repair
@@ -174,23 +176,21 @@ def _is_local_endpoint(
         return True
     if not api_base:
         return False
-    host = api_base.strip().lower().rstrip("/")
-    private_patterns = (
-        "localhost",
-        "127.",
-        "192.168.",
-        "10.",
-        "host.docker.internal",
-        "[::1]",
-    )
-    if any(p in host for p in private_patterns):
+    raw = api_base.strip().lower()
+    parsed = urlparse(raw if "://" in raw else f"//{raw}")
+    try:
+        host = parsed.hostname
+    except ValueError:
+        return False
+    if host in {"localhost", "host.docker.internal"}:
         return True
-    # 172.16.0.0 – 172.31.255.255
-    import re
-    m = re.search(r"172\.(\d+)\." , host)
-    if m and 16 <= int(m.group(1)) <= 31:
-        return True
-    return False
+    if not host:
+        return False
+    try:
+        addr = ip_address(host)
+    except ValueError:
+        return False
+    return addr.is_loopback or addr.is_private
 
 
 def _is_direct_openai_base(api_base: str | None) -> bool:

tests/providers/test_local_endpoint_detection.py

@@ -2,8 +2,6 @@
 
 from unittest.mock import MagicMock
 
-import pytest
-
 from nanobot.providers.openai_compat_provider import (
     OpenAICompatProvider,
     _is_local_endpoint,
@@ -74,6 +72,15 @@ class TestIsLocalEndpoint:
     def test_trailing_slash(self):
         assert _is_local_endpoint(None, "http://192.168.1.1:8080/v1/") is True
 
+    def test_public_hostname_containing_localhost_is_not_local(self):
+        assert _is_local_endpoint(None, "https://notlocalhost.example/v1") is False
+
+    def test_public_hostname_containing_private_ip_prefix_is_not_local(self):
+        assert _is_local_endpoint(None, "https://api10.example.com/v1") is False
+
+    def test_url_without_scheme(self):
+        assert _is_local_endpoint(None, "192.168.1.1:8080/v1") is True
+
 
 class TestLocalKeepaliveConfig:
     """Verify that local endpoints get keepalive_expiry=0."""