refactor: add canonical transcript assembly seam

2026-07-21 00:58:34 +08:00
parent 3ee44de4e5
commit f79f1b3e3b
39 changed files with 1741 additions and 670 deletions
@@ -0,0 +1,69 @@
+import test from 'node:test';
+import assert from 'node:assert/strict';
+import { DatabaseSync } from 'node:sqlite';
+import { mkdtempSync, readFileSync, writeFileSync } from 'node:fs';
+import { tmpdir } from 'node:os';
+import { join } from 'node:path';
+
+import { assembleSessionDetail } from '../app/src/shared/session-detail-assembly.mjs';
+import { persist } from '../packages/core/src/persist.ts';
+import { parse } from '../packages/core/src/providers/codex.ts';
+
+const SCHEMA = readFileSync(new URL('../packages/core/src/schema.sql', import.meta.url), 'utf8');
+const PARENT_ID = '019ed000-0000-7000-8000-000000000101';
+const REPLAY_ID = '019ed000-0000-7000-8000-000000000102';
+
+function writeRollout(path, meta, source) {
+  writeFileSync(path, [
+    { timestamp: '2026-06-15T10:00:00Z', type: 'session_meta', payload: meta },
+    {
+      timestamp: '2026-06-15T10:00:01Z',
+      type: 'response_item',
+      payload: { type: 'custom_tool_call', call_id: 'call_shared', name: 'exec', input: source },
+    },
+    {
+      timestamp: '2026-06-15T10:00:02Z',
+      type: 'response_item',
+      payload: { type: 'custom_tool_call_output', call_id: 'call_shared', output: 'done' },
+    },
+  ].map(line => JSON.stringify(line)).join('\n') + '\n');
+}
+
+test('a replayed Codex call cannot steal the visible message tool association', () => {
+  const dir = mkdtempSync(join(tmpdir(), 'obelisk-codex-replay-'));
+  const parentPath = join(dir, 'parent.jsonl');
+  const replayPath = join(dir, 'replay.jsonl');
+  writeRollout(parentPath, {
+    id: PARENT_ID,
+    timestamp: '2026-06-15T10:00:00Z',
+    cwd: '/proj',
+  }, 'text("parent")');
+  writeRollout(replayPath, {
+    id: REPLAY_ID,
+    forked_from_id: PARENT_ID,
+    timestamp: '2026-06-15T10:00:00Z',
+    cwd: '/proj',
+  }, 'text("replay")');
+
+  const db = new DatabaseSync(':memory:');
+  db.exec(SCHEMA);
+  for (const path of [parentPath, replayPath]) {
+    const unit = { key: path, sessionId: '', meta: { source: 'codex' } };
+    persist(db, unit, parse(unit, null));
+  }
+
+  const sessionId = `codex:${PARENT_ID}`;
+  const messages = db.prepare(
+    'SELECT * FROM messages WHERE session_id=? AND agent_id IS NULL ORDER BY timestamp, uuid',
+  ).all(sessionId);
+  const toolCalls = db.prepare('SELECT * FROM tool_calls WHERE session_id=?').all(sessionId);
+  const toolResults = db.prepare('SELECT * FROM tool_results WHERE session_id=?').all(sessionId);
+  const assembled = assembleSessionDetail({ messages, toolCalls, toolResults, subagents: [], workflows: [] }).messages;
+
+  assert.equal(messages.length, 1, 'the replay remains outside the visible session timeline');
+  assert.equal(toolCalls.length, 2, 'each rollout owns an independently addressable tool call');
+  assert.equal(toolResults.length, 2, 'each rollout owns an independently addressable tool result');
+  assert.deepEqual(assembled[0].tool_calls?.map(call => call.input_json), ['"text(\\"parent\\")"']);
+  assert.equal(assembled[0].tool_calls?.[0].result?.content, 'done');
+  db.close();
+});