Improve onboard wizard setup flow

tests/cli/test_commands.py

@@ -91,12 +91,13 @@ def mock_paths():
 
 
 def test_onboard_fresh_install(mock_paths):
-    """No existing config — should create from scratch."""
+    """No existing config in non-TTY mode should fall back to defaults."""
     config_file, workspace_dir, mock_ws = mock_paths
 
     result = runner.invoke(app, ["onboard"])
 
     assert result.exit_code == 0
+    assert "No interactive terminal detected" in result.stdout
     assert "Created config" in result.stdout
     assert "Created workspace" in result.stdout
     assert "nanobot is ready" in result.stdout
@@ -112,7 +113,7 @@ def test_onboard_existing_config_refresh(mock_paths):
     config_file, workspace_dir, _ = mock_paths
     config_file.write_text('{"existing": true}')
 
-    result = runner.invoke(app, ["onboard"], input="n\n")
+    result = runner.invoke(app, ["onboard", "--defaults"], input="n\n")
 
     assert result.exit_code == 0
     assert "Config already exists" in result.stdout
@@ -121,12 +122,26 @@ def test_onboard_existing_config_refresh(mock_paths):
     assert (workspace_dir / "AGENTS.md").exists()
 
 
+def test_onboard_non_tty_existing_config_refreshes_without_prompt(mock_paths):
+    """Default onboard should not ask overwrite when falling back outside a TTY."""
+    config_file, workspace_dir, _ = mock_paths
+    config_file.write_text("{}")
+
+    result = runner.invoke(app, ["onboard"])
+
+    assert result.exit_code == 0
+    assert "No interactive terminal detected" in result.stdout
+    assert "Config already exists" not in result.stdout
+    assert "existing values preserved" in result.stdout
+    assert workspace_dir.exists()
+
+
 def test_onboard_existing_config_overwrite(mock_paths):
     """Config exists, user confirms overwrite — should reset to defaults."""
     config_file, workspace_dir, _ = mock_paths
     config_file.write_text('{"existing": true}')
 
-    result = runner.invoke(app, ["onboard"], input="y\n")
+    result = runner.invoke(app, ["onboard", "--defaults"], input="y\n")
 
     assert result.exit_code == 0
     assert "Config already exists" in result.stdout
@@ -140,7 +155,7 @@ def test_onboard_existing_workspace_safe_create(mock_paths):
     workspace_dir.mkdir(parents=True)
     config_file.write_text("{}")
 
-    result = runner.invoke(app, ["onboard"], input="n\n")
+    result = runner.invoke(app, ["onboard", "--defaults"], input="n\n")
 
     assert result.exit_code == 0
     assert "Created workspace" not in result.stdout
@@ -164,6 +179,7 @@ def test_onboard_help_shows_workspace_and_config_options():
     assert "--config" in stripped_output
     assert "-c" in stripped_output
     assert "--wizard" in stripped_output
+    assert "--defaults" in stripped_output
     assert "--dir" not in stripped_output
 
 
@@ -172,12 +188,13 @@ def test_onboard_interactive_discard_does_not_save_or_create_workspace(mock_path
 
     from nanobot.cli.onboard import OnboardResult
 
+    monkeypatch.setattr("nanobot.cli.commands._onboard_can_prompt", lambda: True)
     monkeypatch.setattr(
         "nanobot.cli.onboard.run_onboard",
         lambda initial_config: OnboardResult(config=initial_config, should_save=False),
     )
 
-    result = runner.invoke(app, ["onboard", "--wizard"])
+    result = runner.invoke(app, ["onboard"])
 
     assert result.exit_code == 0
     assert "No changes were saved" in result.stdout
@@ -193,7 +210,14 @@ def test_onboard_uses_explicit_config_and_workspace_paths(tmp_path, monkeypatch)
 
     result = runner.invoke(
         app,
-        ["onboard", "--config", str(config_path), "--workspace", str(workspace_path)],
+        [
+            "onboard",
+            "--defaults",
+            "--config",
+            str(config_path),
+            "--workspace",
+            str(workspace_path),
+        ],
     )
 
     assert result.exit_code == 0
@@ -217,11 +241,12 @@ def test_onboard_wizard_preserves_explicit_config_in_next_steps(tmp_path, monkey
         "nanobot.cli.onboard.run_onboard",
         lambda initial_config: OnboardResult(config=initial_config, should_save=True),
     )
+    monkeypatch.setattr("nanobot.cli.commands._onboard_can_prompt", lambda: True)
     monkeypatch.setattr("nanobot.channels.registry.discover_all", lambda: {})
 
     result = runner.invoke(
         app,
-        ["onboard", "--wizard", "--config", str(config_path), "--workspace", str(workspace_path)],
+        ["onboard", "--config", str(config_path), "--workspace", str(workspace_path)],
     )
 
     assert result.exit_code == 0
@@ -232,6 +257,22 @@ def test_onboard_wizard_preserves_explicit_config_in_next_steps(tmp_path, monkey
     assert f"nanobot gateway --config {resolved_config}" in compact_output
 
 
+def test_onboard_wizard_non_tty_falls_back_to_defaults(mock_paths, monkeypatch):
+    config_file, _workspace_dir, _ = mock_paths
+
+    monkeypatch.setattr("nanobot.cli.commands._onboard_can_prompt", lambda: False)
+    monkeypatch.setattr(
+        "nanobot.cli.onboard.run_onboard",
+        lambda initial_config: (_ for _ in ()).throw(AssertionError("should not prompt")),
+    )
+
+    result = runner.invoke(app, ["onboard", "--wizard"])
+
+    assert result.exit_code == 0
+    assert "No interactive terminal detected" in result.stdout
+    assert config_file.exists()
+
+
 def test_config_matches_github_copilot_codex_with_hyphen_prefix():
     config = Config()
     config.agents.defaults.model = "github-copilot/gpt-5.3-codex"