fix(providers): stop writing API keys into process os.environ

OpenAICompatProvider already passes api_key into AsyncOpenAI. Mutating
shared os.environ leaked credentials across providers (gateway overwrite
and setdefault first-writer-wins).

Fixes #4784
This commit is contained in:
LHMQ878
2026-08-12 02:35:40 +09:00
committed by Xubin Ren
parent 99e07e138e
commit f5cf4dcd2c
2 changed files with 48 additions and 17 deletions
@@ -523,9 +523,6 @@ class OpenAICompatProvider(LLMProvider):
self._proxy = proxy or None
self._native_compaction_available = True
if api_key and spec and spec.env_key:
self._setup_env(api_key, api_base)
effective_base = api_base or (spec.default_api_base if spec else None) or None
self._effective_base = effective_base
self._default_headers = {"x-session-affinity": uuid.uuid4().hex}
@@ -618,20 +615,6 @@ class OpenAICompatProvider(LLMProvider):
raise RuntimeError("OpenAI client initialization did not produce a client")
return self._client
def _setup_env(self, api_key: str, api_base: str | None) -> None:
"""Set environment variables based on provider spec."""
spec = self._spec
if not spec or not spec.env_key:
return
if spec.is_gateway:
os.environ[spec.env_key] = api_key
else:
os.environ.setdefault(spec.env_key, api_key)
effective_base = api_base or spec.default_api_base
for env_name, env_val in spec.env_extras:
resolved = env_val.replace("{api_key}", api_key).replace("{api_base}", effective_base)
os.environ.setdefault(env_name, resolved)
@classmethod
def _apply_cache_control(
cls,