Grayscale/nanobot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(providers): drop unreachable GenerationSettings fallback

Browse Source
This commit is contained in:
04cb
2026-04-15 23:52:38 +08:00
committed by Xubin Ren
parent 54f7ad3752
commit eacc9fbb5f
2 changed files with 1 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/providers/test_provider_retry.py
-17
View File
@@ -546,23 +546,6 @@ async def test_chat_with_retry_normalizes_explicit_none_max_tokens() -> None:
assert provider.last_kwargs["temperature"] == 0.7
@pytest.mark.asyncio
async def test_chat_with_retry_hard_fallback_when_generation_max_tokens_is_none() -> None:
"""Final fallback: even if provider.generation.max_tokens is None,
chat() must receive the GenerationSettings class default (not None)."""
provider = ScriptedProvider([LLMResponse(content="ok")])
# Bypass the dataclass type hint by constructing with None explicitly.
provider.generation = GenerationSettings(max_tokens=None, temperature=None) # type: ignore[arg-type]
response = await provider.chat_with_retry(
messages=[{"role": "user", "content": "hi"}],
)
assert response.content == "ok"
assert provider.last_kwargs["max_tokens"] == GenerationSettings.max_tokens
assert provider.last_kwargs["temperature"] == GenerationSettings.temperature
@pytest.mark.asyncio
async def test_chat_stream_with_retry_normalizes_explicit_none_max_tokens() -> None:
"""chat_stream_with_retry must apply the same None-guard as chat_with_retry."""