From 9f3dee0192896471f819b35c3adaa9d41d0bc170 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E6=9D=8E=E6=98=8E=E6=8C=AF?= Date: Mon, 22 Jun 2026 19:12:17 +0800 Subject: [PATCH] docs(dingtalk): clarify disable_private_chat intent in comments Addresses automated review: document that the guard is an intentional hard group-only switch (allowlisted DMs blocked by design) and that str() guards a None sender_id. Comment-only. Co-Authored-By: Claude --- nanobot/channels/dingtalk/runtime.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/nanobot/channels/dingtalk/runtime.py b/nanobot/channels/dingtalk/runtime.py index 1a6cb25f..cbba682d 100644 --- a/nanobot/channels/dingtalk/runtime.py +++ b/nanobot/channels/dingtalk/runtime.py @@ -760,14 +760,15 @@ class DingTalkChannel(BaseChannel): session_key = f"{self.name}:group:{conversation_id}:{sender_id}" if not is_group and self.config.disable_private_chat: - # Private chat is disabled: reply with a notice and drop the - # message before any permission/pairing logic runs, so even - # allowlisted users are redirected to group chat. + # Group-only kill switch: drop DMs with a notice *before* any + # allow_from / pairing check, so even allowlisted senders are + # redirected — intentional, this is a hard private-chat guard + # rather than an authorization decision. No session is created. self.logger.info("private chat disabled; rejecting DM from {}", sender_name) await self.send( OutboundMessage( channel=self.name, - chat_id=str(chat_id), + chat_id=str(chat_id), # str() guards a None sender_id content="该机器人未开启私聊，请在群聊中与我对话。", ) )