simplify(pairing): address review findings — constants, TOCTOU, nesting

- Remove TOCTOU exists() check in _load(); rely on FileNotFoundError
- Define PAIRING_CODE_META_KEY and PAIRING_COMMAND_META_KEY constants
  in nanobot.pairing, replacing magic strings across base.py, slack.py,
  and builtin.py
- Flatten nested revoke logic in handle_pairing_command()
- Trim redundant docstring/comment noise in is_allowed() and generate_code()
This commit is contained in:
chengyongru
2026-05-15 15:46:44 +08:00
committed by Xubin Ren
parent b9522e0a4d
commit 22a0df0c53
5 changed files with 18 additions and 27 deletions
+2 -2
View File
@@ -548,14 +548,14 @@ async def cmd_history(ctx: CommandContext) -> OutboundMessage:
async def cmd_pairing(ctx: CommandContext) -> OutboundMessage:
"""List, approve, deny or revoke pairing requests."""
from nanobot.pairing import handle_pairing_command
from nanobot.pairing import PAIRING_COMMAND_META_KEY, handle_pairing_command
reply = handle_pairing_command(ctx.msg.channel, ctx.args)
return OutboundMessage(
channel=ctx.msg.channel,
chat_id=ctx.msg.chat_id,
content=reply,
metadata={"_pairing_command": True},
metadata={PAIRING_COMMAND_META_KEY: True},
)