simplify(pairing): address review findings — constants, TOCTOU, nesting

- Remove TOCTOU exists() check in _load(); rely on FileNotFoundError
- Define PAIRING_CODE_META_KEY and PAIRING_COMMAND_META_KEY constants
  in nanobot.pairing, replacing magic strings across base.py, slack.py,
  and builtin.py
- Flatten nested revoke logic in handle_pairing_command()
- Trim redundant docstring/comment noise in is_allowed() and generate_code()
This commit is contained in:
chengyongru
2026-05-15 15:46:44 +08:00
committed by Xubin Ren
parent b9522e0a4d
commit 22a0df0c53
5 changed files with 18 additions and 27 deletions
+2 -2
View File
@@ -18,7 +18,7 @@ from nanobot.bus.queue import MessageBus
from nanobot.channels.base import BaseChannel
from nanobot.config.paths import get_media_dir
from nanobot.config.schema import Base
from nanobot.pairing import format_pairing_reply, generate_code, is_approved
from nanobot.pairing import PAIRING_CODE_META_KEY, format_pairing_reply, generate_code, is_approved
from nanobot.utils.helpers import safe_filename, split_message
@@ -351,7 +351,7 @@ class SlackChannel(BaseChannel):
channel=self.name,
chat_id=chat_id,
content=reply,
metadata={"_pairing_code": code},
metadata={PAIRING_CODE_META_KEY: code},
)
)
return