refactor: move SafeFileHistory to module level + add regression tests

- Promote _SafeFileHistory to module-level SafeFileHistory for testability - Add 5 regression tests: surrogates, normal text, emoji, mixed CJK, multi-surrogates Made-with: Cursor
2026-04-07 13:57:34 +08:00
parent 64bd7234b3
commit 075bdd5c3c
2 changed files with 58 additions and 10 deletions
@@ -0,0 +1,44 @@
+"""Regression tests for SafeFileHistory (issue #2846).
+
+Surrogate characters in CLI input must not crash history file writes.
+"""
+
+from nanobot.cli.commands import SafeFileHistory
+
+
+class TestSafeFileHistory:
+    def test_surrogate_replaced(self, tmp_path):
+        """Surrogate pairs are replaced with U+FFFD, not crash."""
+        hist = SafeFileHistory(str(tmp_path / "history"))
+        hist.store_string("hello \udce9 world")
+        entries = list(hist.load_history_strings())
+        assert len(entries) == 1
+        assert "\udce9" not in entries[0]
+        assert "hello" in entries[0]
+        assert "world" in entries[0]
+
+    def test_normal_text_unchanged(self, tmp_path):
+        hist = SafeFileHistory(str(tmp_path / "history"))
+        hist.store_string("normal ascii text")
+        entries = list(hist.load_history_strings())
+        assert entries[0] == "normal ascii text"
+
+    def test_emoji_preserved(self, tmp_path):
+        hist = SafeFileHistory(str(tmp_path / "history"))
+        hist.store_string("hello 🐈 nanobot")
+        entries = list(hist.load_history_strings())
+        assert entries[0] == "hello 🐈 nanobot"
+
+    def test_mixed_unicode_preserved(self, tmp_path):
+        """CJK + emoji + latin should all pass through cleanly."""
+        hist = SafeFileHistory(str(tmp_path / "history"))
+        hist.store_string("你好 hello こんにちは 🎉")
+        entries = list(hist.load_history_strings())
+        assert entries[0] == "你好 hello こんにちは 🎉"
+
+    def test_multiple_surrogates(self, tmp_path):
+        hist = SafeFileHistory(str(tmp_path / "history"))
+        hist.store_string("\udce9\udcf1\udcff")
+        entries = list(hist.load_history_strings())
+        assert len(entries) == 1
+        assert "\udce9" not in entries[0]